Add instance tags to ec2_metadata_facts return values #2398
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 05s |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 53s |
tests/integration/targets/ec2_metadata_facts/playbooks/test_metadata.yml
Show resolved
Hide resolved
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 5m 57s |
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 5m 35s |
|
recheck |
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 3m 37s |
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 5m 10s |
|
recheck |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 9m 19s |
SUMMARY With OpenSSH 9.5 the default format for SSH key generation was switched over to ed25519 (a good thing). However, some older OSes don't support ed25519 (eg the older image we use for testing ec2_metadata_facts python 2 compatibility). setup_sshkey now: Explicitly generates an 4096 bit RSA key (key_material) Generates the somewhat quirky md5sum based fingerprint AWS uses for RSA keys (fingerprint) Explicitly generates an ed25519 key (another_key_material) Pads the standard sha256 fingerprint to match the, technically correct, AWS format (another_fingerprint) ec2_key test now also checks the fingerprint of the second imported key. (Also fixes the issue seen in #2398 by switching ssh key generation back to the old 4096 bit RSA for key_material) ISSUE TYPE Bugfix Pull Request COMPONENT NAME tests/integration/targets/setup_sshkey tests/integration/targets/ec2_key ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis
SUMMARY With OpenSSH 9.5 the default format for SSH key generation was switched over to ed25519 (a good thing). However, some older OSes don't support ed25519 (eg the older image we use for testing ec2_metadata_facts python 2 compatibility). setup_sshkey now: Explicitly generates an 4096 bit RSA key (key_material) Generates the somewhat quirky md5sum based fingerprint AWS uses for RSA keys (fingerprint) Explicitly generates an ed25519 key (another_key_material) Pads the standard sha256 fingerprint to match the, technically correct, AWS format (another_fingerprint) ec2_key test now also checks the fingerprint of the second imported key. (Also fixes the issue seen in #2398 by switching ssh key generation back to the old 4096 bit RSA for key_material) ISSUE TYPE Bugfix Pull Request COMPONENT NAME tests/integration/targets/setup_sshkey tests/integration/targets/ec2_key ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis (cherry picked from commit 5a9d6aa)
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 27s |
softwarefactory-project-zuul
bot
merged commit 43387ec
into
ansible-collections:main
Backport to stable-9: 💚 backport PR created✅ Backport PR branch: Backported as #2408 🤖 @patchback |
SUMMARY Fixes #2293 A list of instance tag keys was added to the return values in version 5.5.0. This adds a new return value that includes the full key:value pairs for the instance tags. ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_metadata_facts Reviewed-by: Mark Chappell Reviewed-by: Helen Bailey <[email protected]> Reviewed-by: Alina Buzachis Reviewed-by: Bikouo Aubin (cherry picked from commit 43387ec)
…2407) This is a backport of PR #2406 as merged into main (5a9d6aa). SUMMARY With OpenSSH 9.5 the default format for SSH key generation was switched over to ed25519 (a good thing). However, some older OSes don't support ed25519 (eg the older image we use for testing ec2_metadata_facts python 2 compatibility). setup_sshkey now: Explicitly generates an 4096 bit RSA key (key_material) Generates the somewhat quirky md5sum based fingerprint AWS uses for RSA keys (fingerprint) Explicitly generates an ed25519 key (another_key_material) Pads the standard sha256 fingerprint to match the, technically correct, AWS format (another_fingerprint) ec2_key test now also checks the fingerprint of the second imported key. (Also fixes the issue seen in #2398 by switching ssh key generation back to the old 4096 bit RSA for key_material) ISSUE TYPE Bugfix Pull Request COMPONENT NAME tests/integration/targets/setup_sshkey tests/integration/targets/ec2_key ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis
This is a backport of PR #2398 as merged into main (43387ec). SUMMARY Fixes #2293 A list of instance tag keys was added to the return values in version 5.5.0. This adds a new return value that includes the full key:value pairs for the instance tags. ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_metadata_facts Reviewed-by: Alina Buzachis
SUMMARY
Fixes #2293
A list of instance tag keys was added to the return values in version 5.5.0. This adds a new return value that includes the full key:value pairs for the instance tags.
ISSUE TYPE
COMPONENT NAME
ec2_metadata_facts